Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BetaProgramInitiator deployment #222

Merged
merged 10 commits into from
Jan 17, 2024
Merged

BetaProgramInitiator deployment #222

merged 10 commits into from
Jan 17, 2024

Conversation

cygnusv
Copy link
Member

@cygnusv cygnusv commented Jan 10, 2024

Type of PR:

  • Bugfix
  • Feature
  • Documentation
  • Other

Required reviews:

  • 1
  • 2
  • 3

What this does:

High-level idea of the changes introduced in this PR.
List relevant API changes (if any), as well as related PRs and issues.

Issues fixed/closed:

  • Fixes #...

Related to #188

Why it's needed:

Explain how this PR fits in the greater context of the NuCypher Network.
E.g., if this PR address a nucypher/productdev issue, let reviewers know!

Notes for reviewers:

What should reviewers focus on?
Is there a particular commit/function/section of your PR that requires more attention from reviewers?

@derekpierre
Copy link
Member

derekpierre commented Jan 12, 2024

Lynx:

NOTE: We may need to update the Coordinator implementation contract on Lynx - it didn't have the feeDeduction method needed by the BetaProgramInitiator contract.

Tapir:

@derekpierre
Copy link
Member

derekpierre commented Jan 15, 2024

Fresh Coordinator implementation contract deployed at https://mumbai.polygonscan.com/address/0x90e112651a57f1484279b9da5c0bd3380e59ceea#code for lynx, and lynx Coordinator proxy contract updated to point to new contract.

@derekpierre derekpierre marked this pull request as ready for review January 15, 2024 16:00
@derekpierre derekpierre changed the title BetaProgramInitiator deployment BetaProgramInitiator deployment Jan 15, 2024
@piotr-roslaniec
Copy link
Contributor

piotr-roslaniec commented Jan 15, 2024

Fresh Coordinator implementation contract deployed at

We need to include these changes in this PR, right?

And that would mandate a bump in @nucypher/nucypher-contracts, na hence @nucypher/taco? We don't need to coordinate it with nucypher/nucypher, right?

@derekpierre
Copy link
Member

derekpierre commented Jan 15, 2024

We need to include these changes in this PR, right?

Yes. One minor update to the ABI in the registry for the feeDeduction method in Coordinator - included now.

We don't need to coordinate it with nucypher/nucypher, right?

From the nucypher/nucypher side it's not needed immediately for functionality because the feeDeduction method (the reason for the update) is not used by the nodes/python code. It is used by the BetaProgramInitiator contract which we can now directly test on lynx and tapir.

And that would mandate a bump in @nucypher/nucypher-contracts, na hence @nucypher/taco?

I suspect taco-web doesn't use feeDeduction either. so no update needed there - but you can let me know if it does.

An update will occur eventually as part of 7.1.x, but I don't think it needs to be immediate because neither client nor server-side need it at the moment.

@piotr-roslaniec
Copy link
Contributor

I suspect taco-web doesn't use feeDeduction either - but you can let me know if it does.

It doesn't, but I still need to use the new Coordinator contract for everything else.

Ok, I think I can implement it now without breaking anything / waiting for 7.1.x.

@derekpierre
Copy link
Member

derekpierre commented Jan 15, 2024

It doesn't, but I still need to use the new Coordinator contract for everything else.

Coordinator is proxied so you are still interacting with the same proxy contract, it's the underlying implementation contract that changed, and that change was an added method which is not used by the client/server libraries.

Copy link
Member Author

@cygnusv cygnusv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't approve because I opened it, but @derekpierre's commits look good to me.

@cygnusv cygnusv merged commit 1e1b98e into nucypher:main Jan 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants